Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new version with semver #609

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 21, 2019

No description provided.

rhatdan added 2 commits March 21, 2019 17:39
Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
@rhatdan
Copy link
Member Author

rhatdan commented Mar 21, 2019

@vrothberg @mtrmac PTAL
We need to get this merged so that we can fix skopeo and then vendor into buildah/podman and cri-o.

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 21, 2019

@vrothberg
Copy link
Member

Is this transitioning to Go modules, and effectively deciding that right now we are freezing the API and making it all public and long-term compatible?

I don't think that's the plan. We can continue rolling fast but need to reflect a bit more about the nature of the merged changes before cutting a release to adhere to the rules of semver regarding what the major.minor.patch parts mean.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 22, 2019

@mtrmac Yes I don't think we are committing to anything, just that if we break the API we move the major version up one.

@rhatdan
Copy link
Member Author

rhatdan commented Mar 22, 2019

As soon as I get this merged, I can update skopeo with the updated version. Can we get this merged?

@vrothberg
Copy link
Member

LGTM

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 22, 2019

As soon as I get this merged, I can update skopeo with the updated version.

I’d prefer to get containers/skopeo#620 updated first, so that tests in here pass the ordinary way; yes, this is likely to be low-risk, but I’d rather not get into the habit of making unnecessary exceptions. (Or, well, anyone who disagrees can just merge this.)

@rhatdan
Copy link
Member Author

rhatdan commented Mar 25, 2019

Skopeo merge has happened.

@vrothberg
Copy link
Member

Thanks, @rhatdan! Tests are green again -> merging.

@vrothberg vrothberg merged commit 1edfec7 into containers:master Mar 25, 2019
@mtrmac mtrmac mentioned this pull request Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants