-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new version with semver #609
Conversation
Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
@vrothberg @mtrmac PTAL |
|
I don't think that's the plan. We can continue rolling fast but need to reflect a bit more about the nature of the merged changes before cutting a release to adhere to the rules of semver regarding what the major.minor.patch parts mean. |
@mtrmac Yes I don't think we are committing to anything, just that if we break the API we move the major version up one. |
As soon as I get this merged, I can update skopeo with the updated version. Can we get this merged? |
LGTM |
I’d prefer to get containers/skopeo#620 updated first, so that tests in here pass the ordinary way; yes, this is likely to be low-risk, but I’d rather not get into the habit of making unnecessary exceptions. (Or, well, anyone who disagrees can just merge this.) |
Skopeo merge has happened. |
Thanks, @rhatdan! Tests are green again -> merging. |
No description provided.