Don't silently ignore errors determining size in TryReuseBlob #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
content-length
branch
from
76f61da to
e473d28
Compare
mtrmac
force-pushed
the
content-length
branch
from
e473d28 to
2a3536a
Compare
When looking for inexact matches, this will cause the matches to be skipped. When checking for an exact match, this will cause an upload failure; we don't have any other way to handle pre-existing blobs on the destination. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
content-length
branch
from
2a3536a to
50a8bb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning the size required by the
TryReuseBlob/PutBlobAPI; otherwise we could put-1into manifests.For now, completely untested.