Update github.com/containerd/containerd to 1.5.9 #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> go get github.com/opencontainers/image-spec@a5463b7f9c8451553af3adcba2cab538469df00c Primarily we want to use a 1.0.3-0... version rather than 1.0.2-0..., so that dependencies on 1.0.2 don't cause any c/image user to use 1.0.2 instead of the later main-branch code. Go has some logic to prevent using pseudo-version that don't follow a released version (which is the case here, where 1.0.2 is on a branch, and we want to use a main-branch commit instead); luckily some later PRs on the main branch include the full contents of the 1.0.2 branch. So, update a bit further along the main branch. (Using a yet later commit would trigger updates to golang/x/crypto which we don't want to deal with in this PR.) Signed-off-by: Miloslav Trmač <[email protected]>
> go get github.com/containerd/containerd@latest ... because 1.5.9 contains a vulnerability fix, and we want to silence scanners. NOTE: c/image DOES NOT use the vulnerable code that was fixed in containerd 1.5.9, so it is NOT vulnerable to GHSA-mvff-h3cj-wj9c . Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
added a commit
to mtrmac/skopeo
that referenced
this pull request
Jan 6, 2022
> go get github.com/opencontainers/image-spec@a5463b7f9c8451553af3adcba2cab538469df00c > make vendor Primarily we want to use a 1.0.3-0... version rather than 1.0.2-0..., so that dependencies on 1.0.2 don't cause Skopeo to use 1.0.2 instead of the later main-branch code. Go has some logic to prevent using pseudo-version that don't follow a released version (which is the case here, where 1.0.2 is on a branch, and we want to use a main-branch commit instead); luckily some later PRs on the main branch include the full contents of the 1.0.2 branch. So, update a bit further along the main branch. This particular commit corresponds to the choice in containers/image#1433 . Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because 1.5.9 contains a vulnerability fix, and we want to silence scanners.
NOTE: c/image DOES NOT use the vulnerable code that was fixed in containerd 1.5.9, so it is NOT vulnerable to GHSA-mvff-h3cj-wj9c .
This PR also updates opencontainers/image-spec to fix using c/image along with other Go modules that reference the 1.0.2 release tag, like containers/buildah#3678 (that includes this containerd update).