Namespaced credentials key enhancements#1373

Merged

rhatdan merged 24 commits intocontainers:mainfrom mtrmac:getcredentials-keys

Dec 1, 2021

+380-368

Commits on Nov 29, 2021

Fold most expected: constants in TestGetAuth to a single line
mtrmac
committed
Automate the key presence checking in TestSetCredentials
mtrmac
committed
Automate the check of GetCredentialsForRef in TestSetCredentials
mtrmac
committed
Don't wrap the test cases in an unnecessary struct in TestSetCredentials
mtrmac
committed
Prepare for having multiple tests in TestGetAllCredentials
mtrmac
committed
Replace noStore with writeKey/expectedKey in TestGetAllCredentials
mtrmac
committed
Remove unused expectedError fields from test cases
mtrmac
committed
Add tests for matching docker.io keys and refs
mtrmac
committed
Add a comment about only looking up credential helpers by registry
mtrmac
committed
Reorganize the success case in getCredentialsWithHomeDir
mtrmac
committed
Introduce a string key in getCredentialsWithHomeDir
mtrmac
committed
Modify findAuthentication to use a string key instead of a reference.Named
mtrmac
committed
Allow using namespaced keys in GetCredentials and GetAuthentication
mtrmac
committed
Rename useLegacyAPI to useLegacyFormat
mtrmac
committed
Fix GetAllCredentials
mtrmac
committed
Reject invalid keys in GetCredentials/GetAuthentication
mtrmac
committed
Also test GetCredentials in TestSetCredentials
mtrmac
committed
Simplify TestGetAuthKeysForKey
mtrmac
committed
Remove testPreviousAPI from TestGetAuth
mtrmac
committed
Be explicit about expected auth values, even if empty, in TestGetAuth
mtrmac
committed
Consolidate hostname and ref into a single "key" in TestGetAuth
mtrmac
committed
Add a test for the docker.io/vendor key
mtrmac
committed
Split TestValidateKey into invalid/valid tests
mtrmac
committed
Make validateKey a bit more strict
mtrmac
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Namespaced credentials key enhancements#1373

Commits on Nov 29, 2021

Fold most expected: constants in TestGetAuth to a single line

Automate the key presence checking in TestSetCredentials

Automate the check of GetCredentialsForRef in TestSetCredentials

Don't wrap the test cases in an unnecessary struct in TestSetCredentials

Prepare for having multiple tests in TestGetAllCredentials

Replace noStore with writeKey/expectedKey in TestGetAllCredentials

Remove unused expectedError fields from test cases

Add tests for matching docker.io keys and refs

Add a comment about only looking up credential helpers by registry

Reorganize the success case in getCredentialsWithHomeDir

Introduce a string key in getCredentialsWithHomeDir

Modify findAuthentication to use a string key instead of a reference.Named

Allow using namespaced keys in GetCredentials and GetAuthentication

Rename useLegacyAPI to useLegacyFormat

Fix GetAllCredentials

Reject invalid keys in GetCredentials/GetAuthentication

Also test GetCredentials in TestSetCredentials

Simplify TestGetAuthKeysForKey

Remove testPreviousAPI from TestGetAuth

Be explicit about expected auth values, even if empty, in TestGetAuth

Consolidate hostname and ref into a single "key" in TestGetAuth

Add a test for the docker.io/vendor key

Split TestValidateKey into invalid/valid tests

Make validateKey a bit more strict