Clean up c/image/docker error handling #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's high time we started collecting error samples and documenting what happens. NOTE: This is NOT an API commitment, we can change the error types and messages any time. Signed-off-by: Miloslav Trmač <[email protected]>
We need at least a smoke test before refactoring the error parser. Ideally we should have a full historical record. Signed-off-by: Miloslav Trmač <[email protected]>
just to minimize repetition; the Reponse qualifier applies to everything in that function, so it doesn't help. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
github.com/docker/distribution is not using the github.com/pkg/errors wrapping mechanism, and we don't expect them to start. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
Body is guaranteed to be present in client's responses. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
No point in handling them in generic code, and callers that aren't expecting StatusPartialContent could be confused. Should not change behavior of GetBlobAt; might in change behavior of other callers if they unexpectedly received the relevant HTTP status codes. This ~mechanically moves the code without much restructuring. Signed-off-by: Miloslav Trmač <[email protected]>
Make it harder to not use the right function. Signed-off-by: Miloslav Trmač <[email protected]>
Don't immediately unwrap an error we have just wrapped. Should not change behavior. Signed-off-by: Miloslav Trmač <[email protected]>
registryHTTPResponseToError expects the response body to be available; don't read it first. Signed-off-by: Miloslav Trmač <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than that bug, this is expected to affect neither error types nor text; it is the hopefully noncontroversial subset of #1299, leaving that PR to focus on the risky changes.
See individual commit messages for details.