Simplify credential normalization, fix tests #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, just iterate and look for the key we want. NOTE: This might change behavior with ambiguous files, we now use the first matching entry, not the last one. Signed-off-by: Miloslav Trmač <[email protected]>
... because the value, at that point. is really supposed to be only a registry. Also adjust failing tests; they were added by commit d30079f . At that point, the argument to getAuth() only could have been a registry, so the test cases were never representative; typically they tested normalization of the lookup key instead of the config entry, when the config entry was what needed normalizing. So, move the URLs and paths to the config file, and remove them from the lookup query, when relevant. Also rework TestGetAuthFromLegacyFile a bit more significantly, so that the test descriptions and test contents actually match instead of being exactly opposite. Signed-off-by: Miloslav Trmač <[email protected]>
vrothberg
reviewed
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for details.