Remove GetCredentials deprecation
#1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@mtrmac PTAL to this one, too :) |
mtrmac
reviewed
Jul 21, 2021
We cannot use `GetCredentialsForRef` if we want to retrieve the credentials for a single registry. This use case is still valid which makes the deprecation of the API obsolete. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
getcredentials-deprecation
branch
from
2814ffc to
16ffe8d
Compare
|
LGTM |
Which one exactly? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use
GetCredentialsForRefif we want to retrieve thecredentials for a single registry. This use case is still valid which
makes the deprecation of the API obsolete.
Refers to containers/common#659 (comment)