Make compressionGoroutine panic-safe again #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
goroutine-patic
branch
3 times, most recently
from
fa0a93d to
5efaa03
Compare
|
LGTM, but needs a rebase @mtrmac |
Commit 3250f2d removed the code that ensures the pipe is closed with error on a goroutine panic, i.e. that the caller does not hang indefinitely, for no clear reason; restore that. Signed-off-by: Miloslav Trmač <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3250f2d from #1084 removed the code that ensures the pipe is closed with error on a goroutine panic, i.e. that the caller does not hang indefinitely, for no clear reason; restore that.