Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decompressing while copying to dir:// #1294

Merged
merged 3 commits into from
Jul 27, 2021

Conversation

moio
Copy link
Contributor

@moio moio commented Jul 7, 2021

This is the accompanying PR for containers/skopeo#1365

@moio moio force-pushed the allow-decompression branch 2 times, most recently from 3e1c61b to f8110b8 Compare July 7, 2021 13:19
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

A design concern I’d like to have more opinion on, + some not-quite-blocking implementation suggestions.

types/types.go Show resolved Hide resolved
directory/directory_transport.go Outdated Show resolved Hide resolved
directory/directory_dest.go Outdated Show resolved Hide resolved
@mtrmac
Copy link
Collaborator

mtrmac commented Jul 7, 2021

Looking at the failing tests, please rebase your branch on top of latest main; hopefully that will help.

@moio moio force-pushed the allow-decompression branch 2 times, most recently from 253e492 to 8463971 Compare July 27, 2021 12:01
Signed-off-by: Silvio Moioli <[email protected]>
@moio moio force-pushed the allow-decompression branch from 8463971 to 401b391 Compare July 27, 2021 12:04
@moio
Copy link
Contributor Author

moio commented Jul 27, 2021

Hopefully it's all good now

@rhatdan
Copy link
Member

rhatdan commented Jul 27, 2021

LGTM
@vrothberg @mtrmac PTAL

Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mtrmac mtrmac merged commit 91e9af4 into containers:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants