Manifest list support nits #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
manifest-list-nits
branch
from
4dbce95 to
8037df1
Compare
... and acknowledge that various tests are strictly speaking invalid, to reinforce that real callers must not pass nil. Signed-off-by: Miloslav Trmač <[email protected]>
nil is a valid value for *types.SystemContext. Signed-off-by: Miloslav Trmač <[email protected]>
It's used to access an ImageStreamImage resource. Signed-off-by: Miloslav Trmač <[email protected]>
- Use a different manifest and manifest list - Write per-arch manifest before the top-level one - Same for signatures - Don't write the top-level manifest twice Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
Missing s.manifest was already checked at the top of the function. Signed-off-by: Miloslav Trmač <[email protected]>
We are definitely going to need it at least in Commit, so compute it already in PutManifest; that fails early and avoids computing it in PutSignatures. Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
We save s.manifest anyway, so avoid the overhead of doing it twice (probably primarily taking the required c/storage lock). Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
The extra hash table it maintains is a bit more expensive, but it allows us to directly express our preferences, and it is more similar to determineManifestConversion (if we ever wanted to add a prioritization for manifest list formats). Also use the two-argument for...range loops to avoid repetition of the long array names. Signed-off-by: Miloslav Trmač <[email protected]>
Signed-off-by: Miloslav Trmač <[email protected]>
... instead of something else + shutting up lint. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
manifest-list-nits
branch
from
8037df1 to
c1d27bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assorted set of small cleanups and some test extensions, mostly related to #400 .
See individual commit messages for details.