Clarify the canModifyBlob condition in copyBlobFromStream #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
mtrmac
force-pushed
the
canModify-isConfig
branch
from
a616b53 to
5637ea6
Compare
The copyConfig caller already sets canModifyBlob to false, set it explicitly inside the function just to make the relationship easier to follow. Also fix some comments. Signed-off-by: Miloslav Trmač <[email protected]>
mtrmac
force-pushed
the
canModify-isConfig
branch
from
5637ea6 to
e5ea852
Compare
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
copyConfigcaller already setscanModifyBlobtofalse, set it explicitly inside the function just to make the relationship easier to follow.Also fix some comments.
Motivated by #1089 (comment) .