copy: wait for progress bars before cleaning up #1023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrmac, I'd love to backport it into Podman 2.0 as we're cutting a new release today. |
Wait for all progress bars to finish before cleaning up. In case of errors, clean up immediately. Waiting for all bars closes a race condition where a bar might not be rendered before being cleaned up. Fixes: containers#1013 Signed-off-by: Valentin Rothberg <[email protected]>
|
Looks like a dead lock caught in the tests |
|
and now a rebase is needed @vrothberg |
|
Closing as I won't find time to tackle it before my PTO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for all progress bars to finish before cleaning up. In case of
errors, clean up immediately. Waiting for all bars closes a race
condition where a bar might not be rendered before being cleaned up.
Fixes: #1013
Signed-off-by: Valentin Rothberg [email protected]