Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple unix socket forwards over ssh #66

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

n1hility
Copy link
Member

@n1hility n1hility commented Oct 21, 2021

This PR extends the unix socket forwarding capability to support multiple socket forwards.

The use-case to extend this to multiple sockets is that podman machine may wish to expose both rootful and rootless ports similar to the original prototype. It follows the same convention as the --listen endpoint for consistency.

Note: To keep the concurrency model simple, it utilizes multiple ssh connections, one per unix socket. Since this is all multiplexed over vsock there isn't much of an advantage to muxing over a single ssh connection anyway.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 21, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: n1hility

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@n1hility
Copy link
Member Author

/cc @guillaumerose

@openshift-ci openshift-ci bot requested a review from guillaumerose October 21, 2021 03:36
@guillaumerose
Copy link
Contributor

lgtm, thanks!

@guillaumerose guillaumerose merged commit ec31c63 into containers:main Oct 21, 2021
@guillaumerose
Copy link
Contributor

guillaumerose commented Oct 21, 2021

Let me know when you need a release @baude @n1hility

You can do brew install podman --head also. It will take podman main branch and this repo main branch.

Copy link
Member

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a possible breaking change of the API. How does this affect consumers?


Gvproxy only, though the tests are defined as generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants