Add --services flag to start API without using --listen flag #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lstocchi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In the current implementation when gvproxy is started with the --listen option, it exposes a HTTP API with several endpoints like /connect, /stats, /services ... The /connect endpoint, however, is only used when the gvforwarder tool is running on the guest, and, when using different connectivities like --listen-vfkit or --listen-qemu, it is not really necessary. This commit adds a new flag --services that allows to start the HTTP API without the /connect endpoint. It could be used when using different network connectivity and still wanting a lighter HTTP API. It accepts the endpoint where it will be reachable E.g. gvproxy --listen-vfkit .... --services unix:///tmp/svc_gvproxy.sock Signed-off-by: Luca Stocchi <[email protected]>
Signed-off-by: Luca Stocchi <[email protected]>
cfergeau
added a commit
to cfergeau/podman
that referenced
this pull request
Dec 13, 2024
This makes use of the new gvproxy parameter added in containers/gvisor-tap-vsock#429
cfergeau
added a commit
to cfergeau/crc
that referenced
this pull request
Dec 18, 2024
At this point, a gvproxy binary built from containers/gvisor-tap-vsock#429 is required. Let's check for it as this requirement is easy to miss.
cfergeau
added a commit
to cfergeau/crc
that referenced
this pull request
Dec 19, 2024
At this point, a gvproxy binary built from containers/gvisor-tap-vsock#429 is required. Let's check for it as this requirement is easy to miss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation when gvproxy is started with the --listen option, it exposes a HTTP API with several endpoints like /connect, /stats, /services ...
The /connect endpoint, however, is only used when the gvforwarder tool is running on the guest, and, when using different connectivities like --listen-vfkit or --listen-qemu, it is not really necessary.
This commit adds a new flag --services that allows to start the HTTP API without the /connect endpoint.
I was not sure how to implement it as I saw 3 possible use cases:
/connectendpoint)/connectendpoint)I went with the third to stick with the same behavior but open to discuss.
I'll add some test in a follow-up PR as I'd like to leverage the code from #427