-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packit: disable builds on podman-next copr #225
Conversation
Podman upstream now syncs the rpm spec file with Fedora dist-git. This podman.spec also builds gvisor-tap-vsock as a subpackage which conflicts with the standalone gvisor-tap-vsock package on podman-next. Ref: containers/podman#18465 This commit will disable build tasks on `rhcontainerbot/podman-next` to avoid installation conflicts. The copr build tasks on every PR will still continue to check for any potential build issues. Signed-off-by: Lokesh Mandvekar <[email protected]>
The rpm built in this repository is more complete than the podman one. gvisor-tap-vsock's spec file installs gvforwarder ( Not directly related to this PR, but some food for thoughts for future improvements :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me if this avoids some mess :)
project: podman-next | ||
#trigger: commit | ||
#branch: main | ||
#project: podman-next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you prefer to keep this code commented out for future reference? Or should it be deleted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep this in so it stares us in the face :)
ohh, |
@cfergeau I'm adding bin/vm to podman upstream rpm spec containers/podman#18707 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Podman upstream now syncs the rpm spec file with Fedora dist-git. This podman.spec also builds gvisor-tap-vsock as a subpackage which conflicts with the standalone gvisor-tap-vsock package on podman-next. Ref: containers/podman#18465
This commit will disable build tasks on
rhcontainerbot/podman-next
to avoid installation conflicts.The copr build tasks on every PR will still continue to check for any potential build issues.
@baude @cfergeau PTAL