Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packit: disable builds on podman-next copr #225

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented May 24, 2023

Podman upstream now syncs the rpm spec file with Fedora dist-git. This podman.spec also builds gvisor-tap-vsock as a subpackage which conflicts with the standalone gvisor-tap-vsock package on podman-next. Ref: containers/podman#18465

This commit will disable build tasks on rhcontainerbot/podman-next to avoid installation conflicts.

The copr build tasks on every PR will still continue to check for any potential build issues.

@baude @cfergeau PTAL

Podman upstream now syncs the rpm spec file with Fedora dist-git.
This podman.spec also builds gvisor-tap-vsock as a subpackage which
conflicts with the standalone gvisor-tap-vsock package on podman-next.
Ref: containers/podman#18465

This commit will disable build tasks on `rhcontainerbot/podman-next` to
avoid installation conflicts.

The copr build tasks on every PR will still continue to check for any
potential build issues.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@cfergeau
Copy link
Collaborator

The rpm built in this repository is more complete than the podman one. gvisor-tap-vsock's spec file installs gvforwarder (bin/vm), and the associated systemd unit files. I guess this is something to solve longer term, maybe by having a standalone gvisor-tap-vsock package in fedora, with 2 distinct subpackages (gvproxy is meant to be installed on a host, while gvforwarder gets installed in a guest).
For gvproxy, it would also be useful to build/provide the macos and windows binaries.

Not directly related to this PR, but some food for thoughts for future improvements :)

Copy link
Collaborator

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me if this avoids some mess :)

project: podman-next
#trigger: commit
#branch: main
#project: podman-next
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you prefer to keep this code commented out for future reference? Or should it be deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this in so it stares us in the face :)

@lsm5
Copy link
Member Author

lsm5 commented May 26, 2023

The rpm built in this repository is more complete than the podman one. gvisor-tap-vsock's spec file installs gvforwarder (bin/vm), and the associated systemd unit files. I guess this is something to solve longer term, maybe by having a standalone gvisor-tap-vsock package in fedora, with 2 distinct subpackages (gvproxy is meant to be installed on a host, while gvforwarder gets installed in a guest). For gvproxy, it would also be useful to build/provide the macos and windows binaries.

ohh, 'bin/vm fell off my radar. My bad. I will get that included in the podman rpm after I cut v4.5.1 containers/podman#18701 . And yes, having a standalone package in Fedora would be ideal.

@lsm5
Copy link
Member Author

lsm5 commented May 26, 2023

@cfergeau I'm adding bin/vm to podman upstream rpm spec containers/podman#18707

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 7, 2023
@cfergeau cfergeau merged commit af8de65 into containers:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants