Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to build gvproxy as Windows GUI (background) app #167

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

arixmkii
Copy link
Contributor

Additional preconfigured build option to use when building for Windows platform. gvproxy will be built as a Windows GUI application.

Using new build configuration to not break potential existent workloads, which are utilizing current console app build.

This is needed to fix containers/podman#16872 (comment)

Signed-off-by: Arthur Sengileyev [email protected]

Copy link
Collaborator

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same flag used by win-sshproxy, so no objection from me

@cfergeau
Copy link
Collaborator

/lgtm

@cfergeau
Copy link
Collaborator

@gbraad @n1hility any additional feedback? If not I'll merge this.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arixmkii, cfergeau

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau cfergeau merged commit aab0ac9 into containers:main Dec 20, 2022
@arixmkii arixmkii deleted the gvproxy-wingui branch July 23, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants