Plug a packet buffer memory leak #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
approved these changes
Oct 25, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cfergeau, stevenmhood The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is missing a DCO before this can be merged, https://github.com/containers/gvisor-tap-vsock/pull/152/checks?check_run_id=9081855178 |
Decrement reference count after queueing the PacketBuffer. Since PacketBuffer objects come from a pool, this allows them to be returned to the pool instead of staying in memory and forcing new allocations. Fixes containers#107 Signed-off-by: stevenmhood <[email protected]>
|
Moved this to re-request, now that the DCO passed, since the other workflows need approval to run. Not sure if you check these periodically or on-demand, either way, no rush from my side. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrement reference count after queueing the PacketBuffer. Since PacketBuffer objects come from a pool, this allows them to be returned to the pool instead of staying in memory and forcing new allocations.
Fixes #107
My interest in fixing this lies in this projects downstream usage in wsl-vpnkit, which grows its memory footprint until my system comes to a standstill (several GB of RAM). With this fix, memory usage stays around 20MB, give or take. Tracing the
NewPacketBuffercall back through the stack exposed thePoolthat underlies thePacketBufferinstances.