Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore ErrUnexpectedEOF in panicCheck and fix lint issue #141

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

balajiv113
Copy link
Contributor

This PR does the following,

  1. Fixes the flaky test as discussed in Update dependencies to latest #135
  2. Fixes the lint issues due to the use of deprecated package io/ioutils

@balajiv113
Copy link
Contributor Author

@gbraad
I believe this PR should fix the flaky test failures and current lint failures as well.
This should bring the CI runs back to green

@n1hility
Copy link
Member

lgtm

@cfergeau
Copy link
Collaborator

cfergeau commented Sep 6, 2022

Rebased on top of main, there's only one commit left: cfergeau@3b4e564
@balajiv113 can you take a look and update this PR?

@balajiv113
Copy link
Contributor Author

@cfergeau sure will look into it and update

@balajiv113
Copy link
Contributor Author

@cfergeau Done the changes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: balajiv113, cfergeau

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau cfergeau merged commit 20771ce into containers:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants