Allow unix sockets on windows #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
reviewed
Aug 18, 2022
|
/lgtm |
gbraad
approved these changes
Aug 19, 2022
|
/hold related to test failure from #135 |
Signed-off-by: Arthur Sengileyev <[email protected]>
|
I've rebased/force-pushed this, and all is green now. @gbraad does this still need to be held? |
|
Would be nice to get this into next stable. |
|
please move ahead |
gbraad
approved these changes
Sep 20, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: arixmkii, gbraad The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go allows to use unix socket in windows. Needed this as part of experiments with containers/podman#13006 As of now I can confirm it is working for forwarding API socket from VM at least. Requires more testing with --qemu-listen over unix socket (probably with modifications of qemu).