fuse-overlayfs: different performance tweaks #88

giuseppe · 2019-07-15T10:24:23Z

this PR has different performance improvements, most notably, there is some initial support for threading. Most of the code is still protected by a lock, so it runs on a single threaded, but operations like read/write/setattr/fsync can be dispatched on a different thread.

It is now possible to disable fsync that seems to slow apt quite significantly. In general it is probably safer to run containers without access to fsync.

The new options can be configured in Podman through ~/.config/containers/storage.conf. I've got the best results with this combination:

mountopt = "threaded=0,fsync=0"

Signed-off-by: Giuseppe Scrivano <[email protected]>

giuseppe · 2019-07-15T13:40:45Z

this needs a fix in SELinux:

type=AVC msg=audit(1563197807.799:377): avc:  denied  { setattr } for  pid=7950 comm="fuse-overlayfs" name="183" dev="proc" ino=160867 scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tcontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tclass=lnk_file permissive=0

giuseppe · 2019-07-15T13:42:19Z

type=AVC msg=audit(1563197807.799:377): avc: denied { setattr } for pid=7950 comm="fuse-overlayfs" name="183" dev="proc" ino=160867 scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tcontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tclass=lnk_file permissive=0

@rhatdan is it possible to enable it only for /proc/self?

rhatdan · 2019-07-15T14:14:39Z

Was this actually blocking? Since this is an unconfined domain it should be allowed. But it looks like a bogus AVC?

A process is attempting to change the attributes of something in /proc/self? The link file is fuse-overlayfs? Is this more about the setattr should be on the thing the link points at?

giuseppe · 2019-07-15T14:23:30Z

the process inside the rootless container was blocked. I'm using /proc/self/FD to change the ownership of a symlink. It seems like the only possible way when dealing with symlinks and fds.

rhatdan · 2019-07-15T14:26:30Z

If this is a container process trying to make this change then it is running with the wrong label. unconfined_t versus container_t.

rhatdan · 2019-07-15T14:27:58Z

type=AVC msg=audit(1563197807.799:377): avc: denied { setattr } for pid=7950 comm="fuse-overlayfs" name="183" dev="proc" ino=160867 scontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tcontext=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023 tclass=lnk_file permissive=0

IE is this supposed to be
container_t writing to unconfined_t lnk_file or
container_t writing to contianer_t lnk_file or
the process running podman writing to the lnk_file, in which case it would be unconfined_t writing to unconfined_t lnk_file.

rhatdan · 2019-07-15T14:30:26Z

No problem allowing
container_t setattr to contianer_t lnk_file or
unconfined_t setattr to unconfined_t lnk_file

Problem with
container_t setattr on unconfined_t lnk_file

giuseppe · 2019-07-15T14:39:36Z

I see. fuse-overlayfs doesn't run in the container, only in its user+mount namespace created by podman

giuseppe · 2019-07-16T11:40:56Z

@rhatdan could we get the unconfined_t setattr to unconfined_t lnk_file fix for selinux?

With this PR fuse-overlayfs performs significantly better.

I've added some new options, such as disabling xattrs. This helps with SELinux as we won't hit the FUSE file system with a getxattr for every operation. Also, disabling fsync seems a sane default for containers, at least for the rootfs where fuse-overlayfs is used. With this in place fuse-overlayfs performs better than native overlay in most cases.

Using mountopt = "noxattrs=1,fsync=0,threaded=0" with rootless podman I get:

$ /usr/bin/time -v podman  run --rm -ti ubuntu:18.04 sh -c 'apt update && apt install -y wine-development'
[.....]
	User time (seconds): 0.15
	System time (seconds): 0.31
	Percent of CPU this job got: 1%
	Elapsed (wall clock) time (h:mm:ss or m:ss): 0:29.64
	Average shared text size (kbytes): 0
	Average unshared data size (kbytes): 0
	Average stack size (kbytes): 0
	Average total size (kbytes): 0
	Maximum resident set size (kbytes): 43416
	Average resident set size (kbytes): 0
	Major (requiring I/O) page faults: 0
	Minor (reclaiming a frame) page faults: 4940
	Voluntary context switches: 4978
	Involuntary context switches: 84
	Swaps: 0
	File system inputs: 16
	File system outputs: 608
	Socket messages sent: 0
	Socket messages received: 0
	Signals delivered: 0
	Page size (bytes): 4096
	Exit status: 0

with root and native overlay:

# /usr/bin/time -v podman  run --rm -ti ubuntu:18.04 sh -c 'apt update && apt install -y wine-development'
[.....]
	User time (seconds): 0.22
	System time (seconds): 0.36
	Percent of CPU this job got: 1%
	Elapsed (wall clock) time (h:mm:ss or m:ss): 0:38.17
	Average shared text size (kbytes): 0
	Average unshared data size (kbytes): 0
	Average stack size (kbytes): 0
	Average total size (kbytes): 0
	Maximum resident set size (kbytes): 43808
	Average resident set size (kbytes): 0
	Major (requiring I/O) page faults: 2
	Minor (reclaiming a frame) page faults: 14456
	Voluntary context switches: 7312
	Involuntary context switches: 186
	Swaps: 0
	File system inputs: 264
	File system outputs: 624
	Socket messages sent: 0
	Socket messages received: 0
	Signals delivered: 0
	Page size (bytes): 4096
	Exit status: 0

rhatdan · 2019-07-16T18:27:18Z

@wrabcak Could you update selinux-policy for Fedora and RHEL7/RHEL8 with
allow unconfined_domain self:lnk_file setattr;

More info: containers/fuse-overlayfs#88 (comment)

wrabcak · 2019-07-16T19:58:48Z

Added to selinux-policy for F29, F30 and Rawhide:
fedora-selinux/selinux-policy@444993d

Signed-off-by: Giuseppe Scrivano <[email protected]>

rhatdan · 2019-07-22T10:57:20Z

main.c


-          if (asprintf (&whiteout_opq_path, "%s/" OPAQUE_WHITEOUT, path) < 0)
-            return -1;
+          sprintf (whiteout_opq_path, "%s/" OPAQUE_WHITEOUT, path);


Should still use snprintf?

rhatdan · 2019-07-22T10:57:38Z

main.c

-      ret = asprintf (&path, "%s/%s", parent->path, name);
-      if (ret < 0)
-        return ret;
+      sprintf (path, "%s/%s", parent->path, name);


rhatdan · 2019-07-22T10:57:50Z

main.c

-      ret = asprintf (&whiteout_path, "%s/%s", parent->path, name);
-      if (ret < 0)
-        return ret;
+      sprintf (whiteout_path, "%s/%s", parent->path, name);


rhatdan · 2019-07-22T10:58:08Z

main.c

-  ret = asprintf (&whiteout_wh_path, "%s/.wh.%s", parent->path, name);
-  if (ret < 0)
-    return ret;
+  sprintf (whiteout_wh_path, "%s/.wh.%s", parent->path, name);


rhatdan · 2019-07-22T10:58:16Z

main.c

-      ret = asprintf (&whiteout_path, "%s/%s", parent->path, name);
-      if (ret < 0)
-        return ret;
+      sprintf (whiteout_path, "%s/%s", parent->path, name);


rhatdan · 2019-07-22T10:58:27Z

main.c

-      ret = asprintf (&whiteout_path, ".wh.%s", name);
-      if (ret < 0)
-        return ret;
+      sprintf (whiteout_path, ".wh.%s", name);


rhatdan · 2019-07-22T10:58:34Z

main.c

-      ret = asprintf (&whiteout_path, "%s/.wh.%s", parent->path, name);
-      if (ret < 0)
-        return ret;
+      sprintf (whiteout_path, "%s/.wh.%s", parent->path, name);


And continue using it fall sprintf calls....

rhatdan · 2019-07-22T10:58:50Z

main.c

-          ret = asprintf (&whiteout_path, ".wh.%s", dent->d_name);
-          if (ret < 0)
-            return NULL;
+          sprintf (whiteout_path, ".wh.%s", dent->d_name);


rhatdan · 2019-07-22T10:59:07Z

main.c

-          ret = asprintf (&path, "%s/%s", pnode->path, name);
-          if (ret < 0)
-            return NULL;
+          sprintf (path, "%s/%s", pnode->path, name);


rhatdan · 2019-07-22T11:06:03Z

Would have been a lot easier to review, if you did a lot of these as separate reviews and documented how they helped improve performance.

Signed-off-by: Giuseppe Scrivano <[email protected]>

mbargull · 2019-07-22T16:39:18Z

Happy to see work fuse-overlayfs' performance.
I can't really comment on/review these changes, but was curious enough to compile and test this branch against a slow-running case I know of. Hopefully the following can be of some use.

This records the time taken to create a couple thousand folders (via seq $count | xargs mkdir) and remove them (via find . -delete) for the different storage drivers for podman:

/usr/bin/fuse-overlayfs --version
/tmp/fuse-overlayfs-gh-88 --version
for storage_option in \
    --storage-driver=vfs \
    --storage-driver=overlay \
    --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs \
    --storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88 \
    ; do
  printf \\n\\n
  for count in 1000 2000 20000 40000 80000 ; do
    podman --root="$(pwd)/containers" ${storage_option} run --rm -qit \
      --workdir=/test --env=count="${count}" --env=TIME="${storage_option} ${count} %S %U %e %C" \
      busybox sh -ec 'seq "${count}" | \time xargs mkdir && \time find . -delete ; printf \\n'
  done
  rm -rf ./containers
done | column -tLN storage,count,sys,user,wall,command -R storage,count,sys,user,wall

fuse-overlayfs: version 0.4.2
FUSE library version 3.6.1
using FUSE kernel interface version 7.29
fusermount3 version: 3.6.1
fuse-overlayfs: version 0.4.2
FUSE library version 3.6.2
using FUSE kernel interface version 7.31
fusermount3 version: 3.6.1
                                                      storage  count    sys  user    wall  command             
                                                                                                               
                                                                                                               
                                         --storage-driver=vfs   1000   0.00  0.00    0.00  xargs    mkdir
                                         --storage-driver=vfs   1000   0.00  0.00    0.00  find     .          -delete
                                                                                                               
                                         --storage-driver=vfs   2000   0.00  0.00    0.00  xargs    mkdir
                                         --storage-driver=vfs   2000   0.01  0.00    0.01  find     .          -delete
                                                                                                               
                                         --storage-driver=vfs  20000   0.03  0.00    0.04  xargs    mkdir
                                         --storage-driver=vfs  20000   0.11  0.02    0.14  find     .          -delete
                                                                                                               
                                         --storage-driver=vfs  40000   0.07  0.01    0.09  xargs    mkdir
                                         --storage-driver=vfs  40000   0.16  0.10    0.28  find     .          -delete
                                                                                                               
                                         --storage-driver=vfs  80000   0.17  0.02    0.19  xargs    mkdir
                                         --storage-driver=vfs  80000   0.36  0.19    0.58  find     .          -delete
                                                                                                               
                                                                                                               
                                                                                                               
                                     --storage-driver=overlay   1000   0.00  0.00    0.00  xargs    mkdir
                                     --storage-driver=overlay   1000   0.00  0.00    0.00  find     .          -delete
                                                                                                               
                                     --storage-driver=overlay   2000   0.00  0.00    0.01  xargs    mkdir
                                     --storage-driver=overlay   2000   0.00  0.00    0.02  find     .          -delete
                                                                                                               
                                     --storage-driver=overlay  20000   0.08  0.00    0.09  xargs    mkdir
                                     --storage-driver=overlay  20000   0.14  0.04    0.19  find     .          -delete
                                                                                                               
                                     --storage-driver=overlay  40000   0.17  0.01    0.19  xargs    mkdir
                                     --storage-driver=overlay  40000   0.26  0.11    0.40  find     .          -delete
                                                                                                               
                                     --storage-driver=overlay  80000   0.36  0.02    0.39  xargs    mkdir
                                     --storage-driver=overlay  80000   0.49  0.26    0.80  find     .          -delete
                                                                                                               
                                                                                                               
                                                                                                               
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs   1000   0.01  0.00    0.07  xargs    mkdir
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs   1000   0.01  0.00    0.12  find     .          -delete
                                                                                                               
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs   2000   0.03  0.00    0.22  xargs    mkdir
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs   2000   0.05  0.00    0.38  find     .          -delete
                                                                                                               
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs  20000   1.77  0.17   15.23  xargs    mkdir
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs  20000   3.05  0.62   31.32  find     .          -delete
                                                                                                               
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs  40000   4.72  0.22   73.52  xargs    mkdir
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs  40000   7.53  1.78  149.06  find     .          -delete
                                                                                                               
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs  80000   9.03  0.61  342.64  xargs    mkdir
  --storage-opt=overlay.mount_program=/usr/bin/fuse-overlayfs  80000  13.89  3.20  673.05  find     .          -delete
                                                                                                               
                                                                                                               
                                                                                                               
  storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88   1000   0.01  0.00    0.05  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88   1000   0.01  0.00    0.09  find     .          -delete
                                                                                                               
  storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88   2000   0.02  0.00    0.15  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88   2000   0.03  0.01    0.24  find     .          -delete
                                                                                                               
  storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88  20000   0.89  0.04    7.10  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88  20000   1.47  0.42   13.53  find     .          -delete
                                                                                                               
  storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88  40000   2.76  0.31   34.43  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88  40000   5.36  1.07   67.84  find     .          -delete
                                                                                                               
  storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88  80000   6.97  0.37  202.25  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88  80000  11.73  3.18  401.59  find     .          -delete

/tmp/fuseoverlayfs-gh-88 is created via the Dockerfile.static from this repository (changed to target this branch) with the state before the last push/GitHub outage.
Overall, speed seems to more or less double compared to the release version, which is nice. The superlinearily increasing time is still observable, though.

Regarding the new options: I have no idea (didn't think about/research it) whether setting fsync=0/fsync=1 should/would affect this test case, but it seems only threaded=0 vs threaded=1 shows a difference:

|> podman --root="$(pwd)/containers" \
|>   --storage-opt='"overlay.mountopt=threaded=0,fsync=0","overlay.mount_program=/tmp/fuse-overlayfs-gh-88"' \
|>   run --rm -qit --workdir=/test --env=TIME='%S %U %e %C' \
|>   busybox sh -ec 'seq 20000 | \time xargs mkdir && \time find . -delete'
0.90 0.07 7.13 xargs mkdir
1.66 0.25 13.43 find . -delete
|> podman --root="$(pwd)/containers" \
|>   --storage-opt='"overlay.mountopt=threaded=0,fsync=1","overlay.mount_program=/tmp/fuse-overlayfs-gh-88"' \
|>   run --rm -qit --workdir=/test --env=TIME='%S %U %e %C' \
|>   busybox sh -ec 'seq 20000 | \time xargs mkdir && \time find . -delete'
0.94 0.04 7.18 xargs mkdir
1.62 0.35 13.52 find . -delete
|> podman --root="$(pwd)/containers" \
|>   --storage-opt='"overlay.mountopt=threaded=1,fsync=0","overlay.mount_program=/tmp/fuse-overlayfs-gh-88"' \
|>   run --rm -qit --workdir=/test --env=TIME='%S %U %e %C' \
|>   busybox sh -ec 'seq 20000 | \time xargs mkdir && \time find . -delete'
1.19 0.03 10.17 xargs mkdir
1.61 0.55 17.83 find . -delete
|> podman --root="$(pwd)/containers" \
|>   --storage-opt='"overlay.mountopt=threaded=1,fsync=1","overlay.mount_program=/tmp/fuse-overlayfs-gh-88"' \
|>   run --rm -qit --workdir=/test --env=TIME='%S %U %e %C' \
|>   busybox sh -ec 'seq 20000 | \time xargs mkdir && \time find . -delete'
1.10 0.11 10.30 xargs mkdir
1.76 0.51 18.03 find . -delete

mbargull · 2019-07-22T17:41:23Z

Re-ran the above with the latest changes from 59cd4c0 :

--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0   1000  0.01  0.00  0.04  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0   1000  0.01  0.00  0.06  find     .          -delete
                                                                                                                    
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0   2000  0.02  0.00  0.09  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0   2000  0.04  0.00  0.13  find     .          -delete
                                                                                                                    
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0  20000  0.20  0.00  0.93  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0  20000  0.35  0.09  1.29  find     .          -delete
                                                                                                                    
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0  40000  0.38  0.02  1.87  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0  40000  0.71  0.19  2.59  find     .          -delete
                                                                                                                    
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0  80000  0.78  0.05  3.76  xargs    mkdir
--storage-opt=overlay.mount_program=/tmp/fuse-overlayfs-gh-88-59cd4c0  80000  1.42  0.42  5.21  find     .          -delete

Some of those changes fixed the non-linear slowness -- massive improvement!

Signed-off-by: Giuseppe Scrivano <[email protected]>

rhatdan · 2019-07-23T10:50:18Z

LGTM
We need to get this into Rawhide first and make sure it does not break anything... Also put it up for fedora updates but make sure everyone on the team installs it. Especially QE. Need to quickly get it into CI/CD tests for podman.

giuseppe · 2019-07-23T12:24:59Z

@mbargull thanks a lot for your tests, I've opened a new PR that should improve the tests case you've reported above: #89

For your test case, the new options should not make any difference, in particular sync=0 is useful when there are too many fsync(2) happening on the file system, it seems to make a huge difference with apt and dpkg.

Could you re-run the test with #89? In general I am curious about the previous released version of fuse-overlayfs vs the version in #89.

giuseppe · 2019-07-23T14:16:47Z

We need to get this into Rawhide first and make sure it does not break anything... Also put it up for fedora updates but make sure everyone on the team installs it. Especially QE. Need to quickly get it into CI/CD tests for podman.

I'll do that once https://bodhi.fedoraproject.org/updates/FEDORA-2019-b156bd756a is finally moved to stable and #89 is also merged

fuse-overlayfs: different performance tweaks continuation of #88

mbargull · 2019-07-25T15:54:21Z

@mbargull thanks a lot for your tests, I've opened a new PR that should improve the tests case you've reported above: #89

With pleasure! Thanks for your work on this. I'll report in gh-91, comparing release 0.4.2, gh-88, gh-89, and gh-91.

For your test case, the new options should not make any difference, in particular sync=0 is useful when there are too many fsync(2) happening on the file system

Right, makes sense, the mkdir/rm test case wouldn't necessarily sync, thanks.

giuseppe · 2019-07-25T16:12:27Z

Sorry I have just opened a new PR. Could you just use that? The intermediate ones don't make much sense to be tested separately

mbargull · 2019-07-25T16:22:11Z

Ah, didn't see comment. Will do, gimme a couple of minutes.

giuseppe added 4 commits July 13, 2019 12:24

perf: enable parallel dirops

809532a

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: use static buffers for paths

3294c8c

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: use faccessat instead of fstatat when possible

4056a2a

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: avoid a stat when possible

d9c5215

Signed-off-by: Giuseppe Scrivano <[email protected]>

giuseppe mentioned this pull request Jul 15, 2019

Rootless overlay whiteouts throw error when stored containers/buildah#1709

Closed

giuseppe force-pushed the perf-improvements branch 3 times, most recently from 64073d8 to 6f3daa5 Compare July 15, 2019 12:00

giuseppe force-pushed the perf-improvements branch 2 times, most recently from a90a5d7 to 7fbe3df Compare July 16, 2019 10:46

giuseppe changed the title ~~[WIP] fuse-overlayfs: different performance tweaks~~ fuse-overlayfs: different performance tweaks Jul 16, 2019

wrabcak added a commit to fedora-selinux/selinux-policy that referenced this pull request Jul 16, 2019

Allow unconfined_domain_type to setattr own process lnk files.

444993d

More info: containers/fuse-overlayfs#88 (comment)

wrabcak added a commit to fedora-selinux/selinux-policy that referenced this pull request Jul 16, 2019

Allow unconfined_domain_type to setattr own process lnk files.

71a2d21

More info: containers/fuse-overlayfs#88 (comment)

wrabcak added a commit to fedora-selinux/selinux-policy that referenced this pull request Jul 16, 2019

Allow unconfined_domain_type to setattr own process lnk files.

6812cbc

More info: containers/fuse-overlayfs#88 (comment)

giuseppe mentioned this pull request Jul 19, 2019

Buildah hangs on buldah commit when being called via buildah unshare containers/buildah#1677

Closed

giuseppe force-pushed the perf-improvements branch 4 times, most recently from 5465213 to 16beb8d Compare July 20, 2019 15:12

giuseppe added 6 commits July 22, 2019 12:34

main: provide implementation for fallocate

b0bc506

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: provide implementation for copy_file_range

648f158

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: provide implementation for forget_multi

1cabb17

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: cache directory nlinks

3154fc0

Signed-off-by: Giuseppe Scrivano <[email protected]>

travis.yml: update libfuse

20fe922

Signed-off-by: Giuseppe Scrivano <[email protected]>

configure: use GNU diff hashing function

d0b363e

Signed-off-by: Giuseppe Scrivano <[email protected]>

rhatdan reviewed Jul 22, 2019

View reviewed changes

giuseppe added 5 commits July 22, 2019 13:07

gnulib: sync from upstream

5653543

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: change initial hash map size to 128

a87044e

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: set keep_cache on open

c1fa9af

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: specify FUSE_CAP_SPLICE_MOVE

53d93f5

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: accept kernel_cache option

3b0ff43

Signed-off-by: Giuseppe Scrivano <[email protected]>

giuseppe force-pushed the perf-improvements branch from 56ad386 to 59cd4c0 Compare July 22, 2019 15:31

giuseppe added 2 commits July 22, 2019 23:17

main: cache if the node has security.capability

1bed1d5

Signed-off-by: Giuseppe Scrivano <[email protected]>

main: store negative lookups

9e20d96

Signed-off-by: Giuseppe Scrivano <[email protected]>

giuseppe force-pushed the perf-improvements branch from 59cd4c0 to 9e20d96 Compare July 22, 2019 21:17

rhatdan merged commit 95e1d01 into containers:master Jul 23, 2019

giuseppe mentioned this pull request Jul 23, 2019

fuse-overlayfs: different performance tweaks continuation of #88 #89

Merged

rhatdan added a commit that referenced this pull request Jul 24, 2019

Merge pull request #89 from giuseppe/perf-improvements-2

bd9eb8d

fuse-overlayfs: different performance tweaks continuation of #88

mbargull mentioned this pull request Jul 25, 2019

perf: improve performance for mkdir and open(O_CREAT) #91

Merged

mbargull mentioned this pull request Jul 28, 2019

do_rm fails to remove directories in upper layer (if whiteouts present?) #93

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fuse-overlayfs: different performance tweaks #88

fuse-overlayfs: different performance tweaks #88

giuseppe commented Jul 15, 2019

giuseppe commented Jul 15, 2019

giuseppe commented Jul 15, 2019

rhatdan commented Jul 15, 2019

giuseppe commented Jul 15, 2019

rhatdan commented Jul 15, 2019

rhatdan commented Jul 15, 2019

rhatdan commented Jul 15, 2019

giuseppe commented Jul 15, 2019

giuseppe commented Jul 16, 2019

rhatdan commented Jul 16, 2019

wrabcak commented Jul 16, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan Jul 22, 2019

rhatdan commented Jul 22, 2019

mbargull commented Jul 22, 2019

mbargull commented Jul 22, 2019

rhatdan commented Jul 23, 2019

giuseppe commented Jul 23, 2019

giuseppe commented Jul 23, 2019

mbargull commented Jul 25, 2019

giuseppe commented Jul 25, 2019

mbargull commented Jul 25, 2019

fuse-overlayfs: different performance tweaks #88

fuse-overlayfs: different performance tweaks #88

Conversation

giuseppe commented Jul 15, 2019

giuseppe commented Jul 15, 2019

giuseppe commented Jul 15, 2019

rhatdan commented Jul 15, 2019

giuseppe commented Jul 15, 2019

rhatdan commented Jul 15, 2019

rhatdan commented Jul 15, 2019

rhatdan commented Jul 15, 2019

giuseppe commented Jul 15, 2019

giuseppe commented Jul 16, 2019

rhatdan commented Jul 16, 2019

wrabcak commented Jul 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rhatdan commented Jul 22, 2019

mbargull commented Jul 22, 2019

mbargull commented Jul 22, 2019

rhatdan commented Jul 23, 2019

giuseppe commented Jul 23, 2019

giuseppe commented Jul 23, 2019

mbargull commented Jul 25, 2019

giuseppe commented Jul 25, 2019

mbargull commented Jul 25, 2019