main: ignore EOVERFLOW when copying xattrs #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the kernel returns EOVERFLOW if the rootid cannot be mapped in the current user namespace when reading the file capabilities (security.capabilities xattr). Signed-off-by: Giuseppe Scrivano <[email protected]>
flouthoc
reviewed
Jun 1, 2022
| @@ -2699,7 +2699,11 @@ copy_xattr (int sfd, int dfd, char *buf, size_t buf_size) | |||
|
|
|||
| s = safe_read_xattr (&v, sfd, it, 256); | |||
| if (s < 0) | |||
| return -1; | |||
| { | |||
| if (errno == EOVERFLOW) | |||
There was a problem hiding this comment.
Just a small doubt/question: should this only ignore when buf contains security.capabilities and not for all the attributes since EOVERFLOW could also mean subsystem incompatibility for other xattrs.
There was a problem hiding this comment.
Shoud we at least write a debug log on this situation.
There was a problem hiding this comment.
this code is used only when we copyup a file. If a xattr cannot be accessed because of EOVERFLOW, I think we should not error out in any case.
We could add a debug message, but I don't think it is going to be very helpful. Log messages from fuse-overlayfs are lost unless it is started manually with --debug.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the kernel returns EOVERFLOW if the rootid cannot be mapped in the
current user namespace when reading the file capabilities
(security.capabilities xattr).
Signed-off-by: Giuseppe Scrivano [email protected]