This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
return dnsmasq errors #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging the rootless cni PR in podman I had a problem with the dnsname plugin because dnsmasq failed to start. The returned error was just `exit status 5`. This is not helpful. To solve this use CombinedOutput and wrap the dnsmasq output to the returned error. Signed-off-by: Paul Holzinger <[email protected]>
|
@mheon @baude @vrothberg Can we get this merged? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the rootless cni PR in podman I had a problem with the
dnsname plugin because dnsmasq failed to start. The returned error was
just
exit status 5. This is not helpful. To solve this use CombinedOutputand wrap the dnsmasq output to the returned error.
Signed-off-by: Paul Holzinger [email protected]