-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cgroup: make target cgroup threaded if needed #931
cgroup: make target cgroup threaded if needed #931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, it is true also in the Gnome workstation scenario where resources are also managed at the upper level, i.e. rootless session level using systemd.
if moving a process fails with EOPNOTSUPP, then change the target cgroup type to threaded and attempt the migration again. Closes: containers#923 Signed-off-by: Giuseppe Scrivano <[email protected]>
1ce198f
to
17d1c16
Compare
Thanks for sparing the time to look into this fellahs (@giuseppe, @flouthoc, @PavelSosin-320). I'm not qualified to comment on any implementation details (I'm a Java dude; learning Go is on my TODO list). But just as a general observation @giuseppe , have you considered writing some kind of "unit test"? From the Do you think that some kind of test(s) that setup the preconditions and expectations/assertions I described in #923 would increase confidence that the original issue, as described, is being addressed? |
Signed-off-by: Giuseppe Scrivano <[email protected]>
let's merge, we can improve it later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
crun is still broken when host is running cgroups v2, waiting for containers/crun#931 to land in a release.
if moving a process fails with EOPNOTSUPP, then change the target
cgroup type to threaded and attempt the migration again.
Closes: #923
Signed-off-by: Giuseppe Scrivano [email protected]