container, exec: honor process user's uid while setting HOME env
#925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If spec contains `process: { user: uid, ...` always honor spec while
performing `exec` and configuring `HOME` env variable.
So `set_home_env` must use `process->user->uid` instead of `container_uid`.
PR also adds a test to verify if we don't regress this in future.
Closes: containers#924
Signed-off-by: Aditya R <[email protected]>
flouthoc
force-pushed
the
fix-exec-home-env
branch
from
fca939f to
ec9ab49
Compare
|
Just re-pushing to fix a type in commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If spec contains
process: { user: uid, ...always honor spec whileperforming
execand configuringHOMEenv variable.So
set_home_envmust useprocess->user->uidinstead ofcontainer_uid.PR also adds a test to verify if we don't regress this in future.
Closes: #924