tests/fuzzing/run-tests.sh: fix flaking #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent commit ff3e33b removed subshell from grep invocation, but overlooked the fact that pipefail option is also set. As a result, we get an occasional exit code 141 (i.e. SIGPIPE) from the script (which was prevented by having a subshell). Since this grep is the only pipe in the script, and we're looking at the exit code from grep, remove "-o pipefail" from it. Signed-off-by: Kir Kolyshkin <[email protected]>
This was referenced Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (hopefully) fixes a flake seen in #843.
Recent commit ff3e33b removed subshell
from grep invocation, but overlooked the fact that pipefail option is
also set. As a result, we get an occasional exit code 141 (i.e. SIGPIPE)
from the script (which was prevented by having a subshell).
Since this grep is the only pipe in the script, and we're looking at the
exit code from grep, remove "-o pipefail" from it.