artifacts: add libprotobuf-c-dev for protobuf headers #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
force-pushed
the
artifacts-protobuf
branch
from
8335fef to
de2a09c
Compare
rst0git
approved these changes
Oct 4, 2021
flouthoc
force-pushed
the
artifacts-protobuf
branch
from
de2a09c to
6c69a71
Compare
rst0git
reviewed
Oct 4, 2021
tests/clang-check/Dockerfile
Outdated
| @@ -1,6 +1,6 @@ | |||
| FROM fedora:latest | |||
|
|
|||
| RUN yum install -y make clang-tools-extra clang python3-pip 'dnf-command(builddep)' && \ | |||
| RUN dnf install protobuf-c -y && yum install -y make clang-tools-extra clang python3-pip 'dnf-command(builddep)' && \ | |||
There was a problem hiding this comment.
Why not yum install -y protobuf-c make clang-tools-extra clang ...'?
There was a problem hiding this comment.
@rst0git Sure but i think protobuf-c is wrong dependency.
There was a problem hiding this comment.
Changing it to protobuf-c-devel
Following commit fixes regression in CI for artifacts. Add libprotobuf-c-dev to dependencies. Signed-off-by: Aditya Rajan <[email protected]>
flouthoc
force-pushed
the
artifacts-protobuf
branch
from
6c69a71 to
44bb0b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following commit fixes regression for artifacts.
Add libprotobuf-c-dev to dependencies.