linux: always remount bind mounts #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it is useful to reset flags like nodev,noexec,nosuid if they are not specified in the bind mount itself. Closes: containers#639 Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
always-remount-with-bind-mounts
branch
from
a4c91b7 to
f642968
Compare
|
tests added |
|
Thanks @giuseppe |
|
@giuseppe would you mind cutting a new release please? Much easier for packaging than adding commits imho. |
|
Update: I confirmed the issue does reproduce on Ubuntu 20.10 w/ |
|
fedora infra is awfully slow today. I'll post bodhi links here after the builds are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is useful to reset flags like nodev,noexec,nosuid if they are not
specified in the bind mount itself.
Closes: #639
Signed-off-by: Giuseppe Scrivano [email protected]