linux: label the cgroup v1 tmpfs #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <[email protected]>
|
@kolyshkin PTAL |
|
LGTM |
kolyshkin
added a commit
to kolyshkin/cri-o
that referenced
this pull request
Nov 1, 2020
This workaround was added a long time ago and the feature should supposedly be fixed by now. Removing it, though, revealed a bug in crun that is being fixed in containers/crun#531. Until the fix is available in a released version, add another workaround. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/cri-o
that referenced
this pull request
Nov 2, 2020
This workaround was added a long time ago and the feature should supposedly be fixed by now. Removing it, though, revealed a bug in crun that is being fixed in containers/crun#531. Until the fix is available in a released version, add another workaround. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/cri-o
that referenced
this pull request
Nov 27, 2020
Among the other things, it comes with the selinux fix from containers/crun#531, so remove the workaround from the integration test suite. Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported here: cri-o/cri-o#4293
Signed-off-by: Giuseppe Scrivano [email protected]