container: truncate pid file before writing it #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 51129eb into 9e1c3de - view on LGTM.com new alerts:
|
Closes: containers#504 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
pid_file_trunc
branch
from
51129eb to
bc1d444
Compare
|
LGTM |
|
@edsantiago @lsm5 ... this might be the flake we've been seeing in Podman CI! |
I'd expect we do not reuse the same file, or is it for the systemd integration? If you have any pointer, I'll happily take a look |
|
I am afraid it is not the same issue. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #504
Signed-off-by: Giuseppe Scrivano [email protected]