Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEWS: tag 0.14 #416

Merged
merged 2 commits into from
Jul 2, 2020
Merged

NEWS: tag 0.14 #416

merged 2 commits into from
Jul 2, 2020

Conversation

giuseppe
Copy link
Member

Closes: #398

Signed-off-by: Giuseppe Scrivano [email protected]

@giuseppe giuseppe mentioned this pull request Jun 25, 2020
Closed
@giuseppe
Copy link
Member Author

need to rebase on top of #418 when it is merged

@giuseppe giuseppe marked this pull request as ready for review July 1, 2020 20:58
@giuseppe
Copy link
Member Author

giuseppe commented Jul 1, 2020

@rhatdan PTAL

@giuseppe giuseppe mentioned this pull request Jul 2, 2020
Merged
@giuseppe giuseppe marked this pull request as draft July 2, 2020 07:27
@giuseppe
Copy link
Member Author

giuseppe commented Jul 2, 2020

blocked again on: #423

@rhatdan
Copy link
Member

rhatdan commented Jul 2, 2020

I just merged in the other fix, does this need a rebase?

@rhatdan
Copy link
Member

rhatdan commented Jul 2, 2020

Does crun --version report the right information?

@giuseppe
Copy link
Member Author

giuseppe commented Jul 2, 2020

Does crun --version report the right information?

yes we take that information at build time from the git version, and include it also in the released tarballs:

$ release-0.14/crun-0.14-static-x86_64 --version
crun version 0.14
commit: 58bf81a59d3233eb4957fda36917f9c76bbc5b11
spec: 1.0.0
+SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +YAJL

@giuseppe giuseppe marked this pull request as ready for review July 2, 2020 12:37
@giuseppe
Copy link
Member Author

giuseppe commented Jul 2, 2020

rebased on top of master

@giuseppe
Copy link
Member Author

giuseppe commented Jul 2, 2020

@edsantiago are you fine with releasing a new version of crun or should I hold it?

@rhatdan
Copy link
Member

rhatdan commented Jul 2, 2020

LGTM
Merge when tests pass.

@giuseppe giuseppe marked this pull request as draft July 2, 2020 14:20
giuseppe added 2 commits July 2, 2020 16:32
@giuseppe
linux: raise error if the pid cannot be found
519fda8 
revert part of c06821d

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe
NEWS: tag 0.14
ebc56fc 
Closes: containers#398

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe marked this pull request as ready for review July 2, 2020 16:47
@giuseppe
Copy link
Member Author

giuseppe commented Jul 2, 2020

@rhatdan I've added another patch :) Please take a look

@giuseppe
Copy link
Member Author

giuseppe commented Jul 2, 2020

moved part of the fix here: containers/buildah#2434

@rhatdan
Copy link
Member

rhatdan commented Jul 2, 2020

LGTM

@rhatdan rhatdan merged commit 9dc881b into containers:master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for new tagged release
2 participants
@giuseppe @rhatdan