Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build s390x binaries using musl libc #1453

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

saschagrunert
Copy link
Member

Building using musl until NixOS/nixpkgs#306473 is resolved.

Refers to cri-o/cri-o#7911

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschagrunert
Copy link
Member Author

Hold a second, I have to add more to derivation.nix.

@saschagrunert
Copy link
Member Author

Alright this works:

> qemu-s390x ./result/bin/crun --version
crun version 1.14.4.0.0.0.32-a85f-dirty
commit: a85f1b404a0f22b88e86a805bd1dd03b81665c22
rundir: /run/user/1000/crun
spec: 1.0.0
+SELINUX +APPARMOR +CAP +SECCOMP +EBPF +YAJL

Building using musl until NixOS/nixpkgs#306473
is resolved.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

Artifact build is green now :)

Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit b4539b5 into containers:main Apr 24, 2024
50 of 52 checks passed
@saschagrunert saschagrunert deleted the s390x-musl branch April 24, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants