-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packit: add jobs for downstream Fedora package builds #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@rhatdan let's get this in before you cut the next release |
@lachmanfrantisek thanks for the review. I added your change too. |
hmm, the packit docs say by default it will modify the release in spec. Gotta set that to false. |
3c3c57b
to
9fdef25
Compare
moved the spec file to The current version of the PR also allows setting Epoch differently on our copr (for copr_username: |
Get rid of `container-selinux.spec.rpkg` in favour of `rpm/container-selinux.spec` which gets synced with fedora dist-git on every upstream release. The version in the new spec file is set to `0` by default and gets updated by packit automatically on every packit task. For local manual rpm builds using the spec, the helper script in the `rpm/` subdir will update the Version field with the latest version found in the upstream repo. Packit will automatically create a PR on fedora dist-git on every new upstream release. A sample PR will look like: https://src.fedoraproject.org/rpms/container-selinux/pull-request/10# A dry run for this can be triggered using: `$ packit propose-downstream --local-content` To run this command locally, you would need to have your packit user-configuration-file set. Ref: https://packit.dev/docs/configuration/#user-configuration-file along with a fedora api key created at: https://src.fedoraproject.org/settings#nav-api-tab with sufficient ACLs. Fixes: containers#231 Co-authored-by: František Lachman <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>
@lachmanfrantisek I made more changes to this PR to be in line with standard packit workflow. There's no more |
@rhatdan PTAL. I guess this is good to go. The spec file in If Frantisek has any further comments, I can work on those in a followup PR. |
LGTM |
Fixes: #231