Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdio: ignore EIO for terminals #441

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

giuseppe
Copy link
Member

when the terminal is closed, we get EIO. Let's treat it as a EOF.

Closes: #440

@rhatdan
Copy link
Member

rhatdan commented Aug 10, 2023

LGTM
@haircommander PTAL

@haircommander
Copy link
Collaborator

you've an fmt error

src/ctr_stdio.c Outdated Show resolved Hide resolved
when the terminal is closed, we get EIO.  Let's treat it as a EOF.

Closes: containers#440

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the ignore-eio-with-pipes branch from f38419a to fa35c74 Compare August 11, 2023 21:15
@haircommander haircommander merged commit 53b3691 into containers:main Aug 14, 2023
@haircommander
Copy link
Collaborator

thanks!

@edsantiago
Copy link
Member

Is there any hope of this fixing containers/podman#10927 ?

@giuseppe
Copy link
Member Author

I am not sure :/ the symptoms look very different

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conmon 246577c0968ed68228b4 <nwarn>: stdio_input read failed Input/output error
4 participants