add log-global-size-max option to limit the total output #342
Conversation
…sses Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
Signed-off-by: Peter Hunt <[email protected]>
|
Does global add any value to the option. Would --logs-size-max work? |
we already have a log-size-max for the log rotation fields. the global is to differentiate the two |
|
--logs-size-max |
|
ahh good idea. Unfortunately we've already shipped cri-o with the flag (and patches to conmon in openshift 🙈 ) so it would end up being tricky to change it now |
|
Ok stick to your wacky option :^(, it is not really used by Humans anyways. |
containers#342 add support for `log-global-size-max` for cri-o/cri-o@a4080bb, but incorrectly name the CLI option as `log-size-global-max`. Signed-off-by: Wong Hoi Sing Edison <[email protected]>
…e-max` containers#342 add support for `log-global-size-max` for cri-o/cri-o@a4080bb, but incorrectly name the CLI option as `log-size-global-max`. Signed-off-by: Wong Hoi Sing Edison <[email protected]>
#342 add support for `log-global-size-max` for cri-o/cri-o@a4080bb, but incorrectly name the CLI option as `log-size-global-max`. Signed-off-by: Wong Hoi Sing Edison <[email protected]>
|
@haircommander would it be a breaking change for CRI-O if we change the behavior of |
|
probably it is still cleaner to add a new option to specify the maximum number of files to keep around |
|
I'm not actually sure. It's used to limit the amount of output on exec probe requests to mitigate a CVE, and we never really concretely promised any behavior on which output would be returned if the exec probe exceeded the max. This change would change the behavior so that we get the end of output instead of beginning. I think you could make an argument in either direction. ultimately, a user would hit this situation if their execs were using way too much output, so I am inclined to say not a breaking change? WDYT @saschagrunert @mrunalp @kwilczynski @sohankunkerkar |
|
yeah I had a quick look at it and I think it will be confusing. It is better a different option to control logs rotation |
related to cri-o/cri-o#5933 and GHSA-fcm2-6c3h-pg6j