logging: new mode -l passthrough #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haircommander PTAL |
giuseppe
force-pushed
the
logging-passthrough
branch
from
b719e03 to
9924797
Compare
|
LGTM |
|
LGTM |
|
I see the following error in the tests: Are we using the correct binary for the CI? :-) |
I'll take a look at what is going on |
giuseppe
force-pushed
the
logging-passthrough
branch
3 times, most recently
from
ff57641 to
d247246
Compare
giuseppe
force-pushed
the
logging-passthrough
branch
2 times, most recently
from
5368dfe to
5a4f735
Compare
giuseppe
force-pushed
the
logging-passthrough
branch
from
5a4f735 to
9802620
Compare
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
when passthrough is specified, the std stream files are passed directly to the container without conmon intercepting them. Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
logging-passthrough
branch
from
9802620 to
7e126e8
Compare
|
rebased. @haircommander does it look good to you? |
|
LGTM, thanks! |
giuseppe
added a commit
to giuseppe/libpod
that referenced
this pull request
Sep 27, 2021
it allows to pass the current std streams down to the container. conmon support: containers/conmon#289 [NO TESTS NEEDED] it needs a new conmon. Signed-off-by: Giuseppe Scrivano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when passthrough is specified, the std stream files are passed directly to the container without conmon intercepting them.
Signed-off-by: Giuseppe Scrivano [email protected]