tty: flush pending data when fd is ready #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
fix-fast-write-tty
branch
from
2c363f5 to
2633ad3
Compare
|
integration tests are not necessarily the fault of this PR. I will look into fixing them today to get this in |
if there was any data already received, make sure it is flushed to the tty as soon as it is opened. Closes: containers/podman#4397 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
fix-fast-write-tty
branch
from
2633ad3 to
19cd107
Compare
|
+1 from me - confirmed that this does resolve my issues! |
|
if cri-o/cri-o#3753 passes I'll merge this and cut 2.0.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if there was any data already received, make sure it is flushed to the tty as soon as it is opened.
Closes: containers/podman#4397
Signed-off-by: Giuseppe Scrivano [email protected]