Support STATUS sd_notify
#311
Comments
|
Interested in opening a PR? |
|
No, because I'm not dev and I never touched Go. Maybe with some indication on where to search in the code I can try. |
|
@vrothberg WDYT? |
|
Thanks for reaching out. This it outside of Podman's hands but something conmon had to support. I'll transfer the issue. |
|
This is where we had to punch: https://github.com/containers/conmon/blob/main/src/conn_sock.c#L371-L383 @giuseppe WDYT? |
|
I just spend the whole day finding out, why this is not working, until I found this issue ;) |
|
@giuseppe WDYT? |
|
since more users are asking for it, I think at this point it is useful to have it. Anyone would like to open a PR? |
alexlarsson
added a commit
to alexlarsson/conmon
that referenced
this issue
Dec 12, 2023
Several of the standard sd-notify messages are safe to use from a container and are very useful. This commit cleans up the general handling of notify messages and allows forwarding of: * READY=1 * RELOADING=1 * STOPPING=1 * WATCHDOG=1 * WATCHDOG=trigger * STATUS=... * ERRNO=... * BUSERROR=... * MONOTONIC_USEC... See https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#Well-known%20assignments for documentation of these. Note: We don't allow unknown messages to be forewarded. For one, all the file-descriptor based ones are currently unsupported (since the forwarding doesn't handle fds), but also some options (current and future) may be security sensitive. This fixes containers#461 and containers#311 Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
added a commit
to alexlarsson/conmon
that referenced
this issue
Dec 12, 2023
Several of the standard sd-notify messages are safe to use from a container and are very useful. This commit cleans up the general handling of notify messages and allows forwarding of: * READY=1 * RELOADING=1 * STOPPING=1 * WATCHDOG=1 * WATCHDOG=trigger * STATUS=... * ERRNO=... * BUSERROR=... * MONOTONIC_USEC... See https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#Well-known%20assignments for documentation of these. Note: We don't allow unknown messages to be forewarded. For one, all the file-descriptor based ones are currently unsupported (since the forwarding doesn't handle fds), but also some options (current and future) may be security sensitive. fixes containers#461 fixes containers#311 Signed-off-by: Alexander Larsson <[email protected]>
alexlarsson
added a commit
to alexlarsson/conmon
that referenced
this issue
Dec 12, 2023
Several of the standard sd-notify messages are safe to use from a container and are very useful. This commit cleans up the general handling of notify messages and allows forwarding of: * READY=1 * RELOADING=1 * STOPPING=1 * WATCHDOG=1 * WATCHDOG=trigger * STATUS=... * ERRNO=... * BUSERROR=... * MONOTONIC_USEC... See https://www.freedesktop.org/software/systemd/man/latest/sd_notify.html#Well-known%20assignments for documentation of these. Note: We don't allow unknown messages to be forewarded. For one, all the file-descriptor based ones are currently unsupported (since the forwarding doesn't handle fds), but also some options (current and future) may be security sensitive. fixes containers#461 fixes containers#311 Signed-off-by: Alexander Larsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/kind feature
Description
Support sd_notify
STATUSActually, podman
3.4.1only supportWATCHDOGandREADYnotification when using--sdnotify=container.That would be interesting to integrate more messages, like
STATUSThe text was updated successfully, but these errors were encountered: