Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output hanging #236

Closed
olivier-m opened this issue Jan 30, 2021 · 5 comments · Fixed by #237
Closed

output hanging #236

olivier-m opened this issue Jan 30, 2021 · 5 comments · Fixed by #237

Comments

@olivier-m
Copy link

Hi,

Since after version 2.0.22 a large amount of data in stdout/stderr hangs the output and all I can do is ctrl+c and podman kill the container.
Here's how to reproduce:

podman run -rm -ti alpine

Once in the shell:

find /

I also encountered issues with vscode trying to reconnect to a container (it might be related) and failing a lot.
The same steps with 2.0.22 work just fine.

I investigated a little but couldn't find anything, sorry. Might it be related to 0f092d5?

@haircommander
Copy link
Collaborator

@giuseppe can you PTAL

@justinkb
Copy link

justinkb commented Feb 1, 2021

caused by 6287bd8, see my investigation here

containers/podman#9183

reverting it (applies cleanly) fixes the issue entirely

giuseppe added a commit to giuseppe/conmon that referenced this issue Feb 2, 2021
commit 6287bd8 introduced the
regression.

writes to the attached sockets must be blocking, otherwise the
write_back_to_remote_consoles() shutdowns the socket when write fails
with EAGAIN.

I've verified the original issue fixed with commit 62887bd is not
reintroduced with this patch.

Closes: containers#236

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe
Copy link
Member

giuseppe commented Feb 2, 2021

this part of the code is a mess :(

Opened a PR: #237

haircommander pushed a commit that referenced this issue Feb 2, 2021
commit 6287bd8 introduced the
regression.

writes to the attached sockets must be blocking, otherwise the
write_back_to_remote_consoles() shutdowns the socket when write fails
with EAGAIN.

I've verified the original issue fixed with commit 62887bd is not
reintroduced with this patch.

Closes: #236

Signed-off-by: Giuseppe Scrivano <[email protected]>
@justinkb
Copy link

justinkb commented Feb 2, 2021

I will try your fix later tonight!

edit: confirming it works now

@olivier-m
Copy link
Author

Just tried with 2.0.26 today and it works! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants