Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL: Inject context after creating debug span #816

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This leads into a way more cleaner alignment between RPCs and spans, for example when running:

> export CTR=(sudo crictl run test/testdata/container_redis.json test/testdata/sandbox_config.json)
> sudo crictl exec -its $CTR echo 1
> sudo crictl exec -its $CTR echo 2 
> sudo crictl rmp -fa

Will now outline the right CRI-O RPC and conmon-rs spans:

screenshot

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

This leads into a way more cleaner alignment between RPCs and spans.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #816 (9f3e2b6) into main (b1ddf32) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #816   +/-   ##
=======================================
  Coverage   31.70%   31.70%           
=======================================
  Files          13       13           
  Lines        1129     1129           
  Branches      428      427    -1     
=======================================
  Hits          358      358           
  Misses        487      487           
  Partials      284      284           

@rphillips
Copy link
Collaborator

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants