Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #776

Merged
merged 2 commits into from
Oct 6, 2022
Merged

Small fixes #776

merged 2 commits into from
Oct 6, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

A bunch of small fixes:

  • Make client log driver default to systemd
  • Sort Cargo.toml dependencies alphabetically

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Default golang client server log driver to systemd.

This streamlines the conmonrs server default with the golang client.

Signed-off-by: Sascha Grunert <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 6, 2022
@rphillips
Copy link
Collaborator

/lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #776 (dbc67ba) into main (2cb430c) will decrease coverage by 0.44%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   31.79%   31.35%   -0.45%     
==========================================
  Files          13       13              
  Lines        1129     1129              
  Branches      429      429              
==========================================
- Hits          359      354       -5     
- Misses        485      491       +6     
+ Partials      285      284       -1     

@saschagrunert saschagrunert merged commit 75562ef into containers:main Oct 6, 2022
@saschagrunert saschagrunert deleted the systemd-std branch October 10, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants