Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to lcov code coverage #2468

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

The -Zprofile flag has been removed in nightly: rust-lang/rust#131829

We should switch over to an alternative and will use the llvm cov cargo format instead.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Signed-off-by: Sascha Grunert <[email protected]>
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.42%. Comparing base (4e0f474) to head (e312083).
Report is 815 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2468       +/-   ##
===========================================
- Coverage   37.53%    5.42%   -32.12%     
===========================================
  Files          15     1819     +1804     
  Lines        1268   254720   +253452     
  Branches      414        0      -414     
===========================================
+ Hits          476    13810    +13334     
- Misses        526   240910   +240384     
+ Partials      266        0      -266     

@haircommander
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 4, 2024
@saschagrunert saschagrunert merged commit 9977a31 into containers:main Nov 4, 2024
32 of 35 checks passed
@saschagrunert saschagrunert deleted the codecov branch November 4, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants