Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo vendor #2414

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix cargo vendor #2414

merged 1 commit into from
Sep 10, 2024

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind ci

What this PR does / why we need it:

Seems like the latest rust version changes something in vendor.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Signed-off-by: Sascha Grunert <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.23%. Comparing base (4e0f474) to head (fbb073f).
Report is 722 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2414       +/-   ##
===========================================
+ Coverage   37.53%   63.23%   +25.69%     
===========================================
  Files          15      121      +106     
  Lines        1268     4007     +2739     
  Branches      414      830      +416     
===========================================
+ Hits          476     2534     +2058     
- Misses        526     1473      +947     
+ Partials      266        0      -266     

@saschagrunert saschagrunert changed the title WIP: Fix cargo vendor Fix cargo vendor Sep 10, 2024
@saschagrunert
Copy link
Member Author

@kwilczynski PTAL

@kwilczynski
Copy link
Member

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 06f131d into containers:main Sep 10, 2024
37 checks passed
@saschagrunert saschagrunert deleted the vendor branch September 10, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants