Update ginkgo to v2.12.0 #1706
Merged
Update ginkgo to v2.12.0 #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1706 +/- ##
==========================================
+ Coverage 34.57% 34.92% +0.34%
==========================================
Files 13 13
Lines 1151 1151
Branches 369 371 +2
==========================================
+ Hits 398 402 +4
Misses 520 520
+ Partials 233 229 -4 |
saschagrunert
force-pushed
the
ginkgo
branch
from
781f56b to
fd55f67
Compare
saschagrunert
commented
Sep 18, 2023
saschagrunert
force-pushed
the
ginkgo
branch
3 times, most recently
from
63ba35f to
b922965
Compare
saschagrunert
force-pushed
the
ginkgo
branch
2 times, most recently
from
80590d2 to
734d363
Compare
|
/lgtm |
|
@saschagrunert could you rebase this with main - pulling in the memory patch? |
Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
ginkgo
branch
from
734d363 to
c34908b
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind ci
What this PR does / why we need it:
Update the ginkgo version to match the latest one in CI.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?