Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPR: Exclude ELN builds #1451

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jun 28, 2023

The packit workflow for Podman and other repos has recently changed to include the official rpm spec file upstream and have Fedora dist-git sync from upstream on every release.
Ref: containers/podman#18465

This has made it necessary to verify ELN package build success in our copr builds. And enabling ELN on copr is causing conmon-rs failures Ref: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/6121423/

Since ELN is not an immediate concern, this commit will only do copr builds for centos stream and fedora rawhide, 38 and 37.

What type of PR is this?

/kind other

What this PR does / why we need it:

Disable ELN buildroot for copr builds

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

The packit workflow for Podman and other repos has recently changed to
include the official rpm spec file upstream and have Fedora dist-git
sync from upstream on every release.
Ref: containers/podman#18465

This has made it necessary to verify ELN package build success in our
copr builds. And enabling ELN on copr is causing conmon-rs failures
Ref: https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/build/6121423/

Since ELN is not an immediate concern, this commit will only do copr
builds for centos stream and fedora rawhide, 38 and 37.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5
Copy link
Member Author

lsm5 commented Jun 28, 2023

@haircommander @jakecorrenti PTAL.

@haircommander
Copy link
Collaborator

LGTM

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 29, 2023
@openshift-merge-robot openshift-merge-robot merged commit f452791 into containers:main Jun 29, 2023
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, lsm5, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [haircommander,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5 lsm5 deleted the disable-eln branch July 3, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants