-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add codespell job to GHA #990
CI: add codespell job to GHA #990
Conversation
Brought to you by make codespell Signed-off-by: Kir Kolyshkin <[email protected]>
Wait, it doesn't work as intended; will fix |
s/splitted/split/g Signed-off-by: Kir Kolyshkin <[email protected]>
Rename hist to history. Signed-off-by: Kir Kolyshkin <[email protected]>
Move codespell options from Makefile to .codespellrc. While at it, remove some exclusions that apparently are no longer needed. Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
OK, working now, no longer a draft. I took a liberty to fix a few typos found by codespell that were previously excluded. You can see how the job works in https://github.com/kolyshkin/common/actions |
/approve One thing I could never get codespell to ignore was ERRO verus ERROR |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CI failure (https://cirrus-ci.com/task/6239893218131968) is obviously unrelated; I see Dan has it restarted. |
Apparently we do have codespell target in Makefile, but it is not used by any CI.
Fix all issues found by codespell, and create a small GHA CI job to run it for all PRs, branches and tags.