Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add codespell job to GHA #990

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

kolyshkin
Copy link
Contributor

Apparently we do have codespell target in Makefile, but it is not used by any CI.

Fix all issues found by codespell, and create a small GHA CI job to run it for all PRs, branches and tags.

Brought to you by

	make codespell

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin marked this pull request as draft March 30, 2022 18:29
@kolyshkin
Copy link
Contributor Author

Wait, it doesn't work as intended; will fix

s/splitted/split/g

Signed-off-by: Kir Kolyshkin <[email protected]>
Rename hist to history.

Signed-off-by: Kir Kolyshkin <[email protected]>
Move codespell options from Makefile to .codespellrc.

While at it, remove some exclusions that apparently are no longer
needed.

Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Contributor Author

OK, working now, no longer a draft. I took a liberty to fix a few typos found by codespell that were previously excluded.

You can see how the job works in https://github.com/kolyshkin/common/actions

@kolyshkin kolyshkin marked this pull request as ready for review March 30, 2022 18:43
@rhatdan
Copy link
Member

rhatdan commented Mar 30, 2022

/approve
/LGTM

One thing I could never get codespell to ignore was ERRO verus ERROR

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kolyshkin
Copy link
Contributor Author

CI failure (https://cirrus-ci.com/task/6239893218131968) is obviously unrelated; I see Dan has it restarted.

@openshift-merge-robot openshift-merge-robot merged commit 310f063 into containers:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants