-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPCMode default mode should be sharable not private #972
Conversation
@containers/podman-maintainers PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a description to the commit message why it should be shareable.
Changes LGTM
why do we need a new mode and how is it different from |
Docker defined --ipc=private to mean that the container's IPC Namespace can NOT be shared with another container. While --ipc=shareable can, which is our current default. Docker also defines "none" which means the container runs in a IPC namespace but does NOT mount a /dev/shm. "Host" means the container runs in the host namespace, and container:UUID means run new container in other containers namespace. ns:PATH means run in the namepsace designated in PATH. |
Docker defined --ipc=private to mean that the container's IPC Namespace can NOT be shared with another container. While --ipc=shareable can, which is our current default. Docker also defines "none" which means the container runs in a IPC namespace but does NOT mount a /dev/shm. "Host" means the container runs in the host namespace, and container:UUID means run new container in other containers namespace. ns:PATH means run in the namepsace designated in PATH.2 This Patch, fixes containers/common to reflect the correct default. Signed-off-by: Daniel J Walsh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Docker defined --ipc=private to mean that the container's IPC Namespace
can NOT be shared with another container. While --ipc=shareable can,
which is our current default. Docker also defines "none" which means
the container runs in a IPC namespace but does NOT mount a /dev/shm.
"Host" means the container runs in the host namespace, and
container:UUID means run new container in other containers namespace.
ns:PATH means run in the namepsace designated in PATH.2
This Patch, fixes containers/common to reflect the correct default.
Signed-off-by: Daniel J Walsh [email protected]