Add new pkg/sysctl package #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
force-pushed
the
sysctl
branch
3 times, most recently
from
de12e5a to
5a65c97
Compare
vrothberg
reviewed
Mar 23, 2020
pkg/sysclt/sysctl.go
Outdated
| ) | ||
|
|
||
| // ValidateSysctls validates a list of sysctl and returns it. | ||
| func ValidateSysctls(strSlice []string) (map[string]string, error) { |
There was a problem hiding this comment.
Can we call it just Validate? Calling sysctl.ValidateSysctls seems redundant.
Allow for the validation of sysctls passed into container engines. Signed-off-by: Daniel J Walsh <[email protected]>
Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM |
M1cha
pushed a commit
to M1cha/common
that referenced
this pull request
Dec 20, 2022
…de_json-1.0.72 build(deps): bump serde_json from 1.0.71 to 1.0.72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for the validation of sysctls passed into container engines.
Signed-off-by: Daniel J Walsh [email protected]