libnetwork: allow new none ipam driver #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
/hold |
|
Looks like this needs a rebase (Podman PR anyways.) |
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Mar 28, 2022
Allow creating interfaces only with no ip addresses assigned. Ref containers/common#967 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Mar 28, 2022
Allow creating interfaces only with no ip addresses assigned. I combined the macvlan and bridge code to prevent unessesary duplication and bugs. Ref containers/common#967 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Mar 28, 2022
Allow creating interfaces only with no ip addresses assigned. Also combine some duplicated code for bridge/macvlan. Ref containers/common#967 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Mar 28, 2022
Allow creating interfaces only with no ip addresses assigned. Also combine some duplicated code for bridge/macvlan. Ref containers/common#967 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/netavark
that referenced
this pull request
Mar 29, 2022
Allow creating interfaces only with no ip addresses assigned. Also combine some duplicated code for bridge/macvlan. Ref containers/common#967 Signed-off-by: Paul Holzinger <[email protected]>
Parse no ipam plugin and display it as ipam driver none. Also set the ipam driver field for unsupported plugins. Signed-off-by: Paul Holzinger <[email protected]>
Network create now uses the ipam driver. This allows the user to configure the ipam driver manually instead of choosing a fixed default. If the ipam driver is `none` no cni ipam plugin will be added to teh config. This means that the interfaces are created but no extra ip addresses are assigned. Signed-off-by: Paul Holzinger <[email protected]>
When we read the cni result we should loop over the interfaces and then the ips. If we only loop over ips we will miss interfaces that have no ips assigned. We also only care about interfaces created in the netns. This is required for ipam driver none case, see the test case. Signed-off-by: Paul Holzinger <[email protected]>
Network create now uses the ipam driver. This allows the user to configure the ipam driver manually instead of choosing a fixed default. If the ipam driver is `none` no ips will be assigned to this container. This means that only the interfaces are created. This will require a patch in netavark since it rejects the config when no static ips are provided. Ref containers/podman#13521 Signed-off-by: Paul Holzinger <[email protected]>
The gocyclo linter is complaining that the cyclomatic complexity is to high for `(*cniNetwork).createCNIConfigListFromNetwork()`. Split out option parsing to a new funtion should reduce the complexity. Signed-off-by: Paul Holzinger <[email protected]>
|
LGTM |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network create now uses the ipam driver. This allows the user to
configure the ipam driver manually instead of choosing a fixed default.
If the ipam driver is
noneno ips will be assigned to this container.This means that only the interfaces are created.
This will require a patch in netavark since it rejects the config when
no static ips are provided.
Ref containers/podman#13521