Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse: allow extra options for idmap #927

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

giuseppe
Copy link
Member

allow to pass extra information for idmap down to the OCI runtime.

Signed-off-by: Giuseppe Scrivano [email protected]

allow to pass extra information for idmap down to the OCI runtime.

Signed-off-by: Giuseppe Scrivano <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Feb 14, 2022

LGTM
@haircommander PTAL

@rhatdan
Copy link
Member

rhatdan commented Feb 14, 2022

@containers/podman-maintainers PTAL

@haircommander
Copy link
Contributor

LGTM

@rhatdan rhatdan merged commit 0265e6b into containers:main Feb 14, 2022
giuseppe added a commit to giuseppe/libpod that referenced this pull request Feb 16, 2022
[NO NEW TESTS NEEDED] the feature is still being worked in crun:

containers/crun#874

also needs: containers/common#927

Signed-off-by: Giuseppe Scrivano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants