libimage: normalize platform #867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
How did that sneak in? |
|
Fixed |
|
Changes LGTM, but would like a head nod from @nalind . CI still hates you @vrothberg , what did you ever do to it? |
|
Cross builds were not run on each PR until recently. |
|
LGTM |
vrothberg
force-pushed
the
libimage-platform-normalization
branch
from
bcad9ff to
9c94540
Compare
|
Rebased to get cross-build fixes in. |
Buildah, containers and probably other container engines are normalizing the platform parameters to support common values. For instance, "x86_64" is normalized to the OCI conformant "amd64". Use the same normalization when copying images and looking up local images. Also add some debug logs to facilitate future debugging. Fixes: containers/podman/issues/12680 Signed-off-by: Valentin Rothberg <[email protected]>
vrothberg
force-pushed
the
libimage-platform-normalization
branch
from
9c94540 to
b2d805e
Compare
|
@rhatdan PTAL |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildah, containers and probably other container engines are normalizing
the platform parameters to support common values. For instance, "x86_64"
is normalized to the OCI conformant "amd64".
Use the same normalization when copying images and looking up local
images. Also add some debug logs to facilitate future debugging.
Fixes: containers/podman/issues/12680
Signed-off-by: Valentin Rothberg [email protected]
@containers/podman-maintainers PTAL
@rhatdan PTAL
@nalind FYI